hooks: update scikit-image hooks for compatibility with 0.19.x and 0.20.0 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
hooks-scikit-image-update
branch
from
7cb895a
to
5d355b4
Compare
|
Oneshot test: https://github.com/rokm/pyinstaller-hooks-contrib/actions/runs/4577015129 (@bwoodsend any plans for merging your |
bwoodsend
approved these changes
Mar 31, 2023
Update the `skimage.filters` hook to account for the lazy module loading within this module.
Account for introducion of the `lazy_loader` in the main package and in `skimage.data` and `skimage.filters`; collect the `__init__.pyi` files (required by `lazy_loader`), and collect submodules where necessary. Also collect the data files that are now required by `skimage.morphology`.
The `skimage.viewer` module was removed in scikit-image 0.20.0, so remove the test.
rokm
force-pushed
the
hooks-scikit-image-update
branch
from
5d355b4
to
5dfaacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scikit-image hooks for compatibility with 0.19.x and 0.20.0. The 0.19.x series introduced custom lazy module loader, which in our case affects
skimage.filters. In 0.20.0, they switched tolazy_loader, which requires us to collect__init__.pyifiles. In additionskimage.morphologyintroduced two mandatory .npy data files that it tries to load at import.Supersedes and closes #565.